Migrate InteractionManager - (Newly added usages) part 2#94474
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59e7a1e193
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@Pujan92 @ikevin127 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e53fb0ab3c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppSimulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-30.at.19.22.49.movSimulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-30.at.19.21.11.movSimulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-30.at.19.16.00.movSimulator.Screen.Recording.-.iPhone.15.Pro.-.2026-06-30.at.19.31.29.moviOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-06-30.at.18.59.20.movScreen.Recording.2026-06-30.at.18.56.49.movScreen.Recording.2026-06-30.at.18.53.33.movScreen.Recording.2026-06-30.at.18.50.40.movScreen.Recording.2026-06-30.at.18.48.04.movScreen.Recording.2026-06-30.at.18.47.21.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.26-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR. It is a purely internal refactor that migrates the remaining There are no changes to any feature, setting, tab, label, button, or user-facing behavior. Nothing in If a reviewer believes any user-visible behavior actually changed (e.g., a new or altered flow that the help site documents), let me know the specific behavior and I'll re-scope the docs. |
|
This PR failing because of the issue #95125 |
|
@jponikarchuk I'm on it! |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Migrates remaining
InteractionManager.runAfterInteractionsusages toTransitionTracker.runAfterTransitions. The customTransitionTrackeris transition-aware and supports awaitForUpcomingTransitionflag for callers that dispatch navigation before cleanup. Several sites that wrapped trivial calls inInteractionManagerunnecessarily had the wrapper removed entirely.Fixed Issues
$ #71913
$ #83071
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Test 1:
1.mov
Test 2:
2.mov
Test 3:
3.mov